Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure property order for NotificationOrderExt models #537

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Ensure property order for NotificationOrderExt models #537

merged 4 commits into from
Jun 5, 2024

Conversation

acn-sbuad
Copy link
Contributor

@acn-sbuad acn-sbuad commented Jun 5, 2024 •
edited
Loading

Description

Base properties such as id and creator now appear before model specific properties such as processing status or email template

@SandGrainOne
Copy link
Member

Are any of these models included in the order request and will this force clients to list properties in a specific order?

tba76
tba76 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@tba76 tba76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🍺

@acn-sbuad
Copy link
Contributor Author

Are any of these models included in the order request and will this force clients to list properties in a specific order?

@SandGrainOne Order request has seperate models. Either way jsonPropertyOrder only affect serialization and not deserialization.

@acn-sbuad acn-sbuad merged commit c5b3018 into main Jun 5, 2024
2 of 3 checks passed
@acn-sbuad acn-sbuad deleted the chore/new-property-order branch June 5, 2024 10:18
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@acn-sbuad
Copy link
Contributor Author

Property order verified in AT22

{
  "id": "59b1d86d-fe39-44e5-b47f-f4677e610f32",
  "requestedSendTime": "2024-05-30T12:45:25.546319Z",
  "creator": "ttd",
  "created": "2024-05-30T12:45:25.5470899Z",
  "notificationChannel": "Email",
  "resourceId": "app_ttd_apps-test",
  "recipients": [
    {
      "organizationNumber": "313009955"
    }
  ],
  "emailTemplate": {
    "fromAddress": "[email protected]",
    "subject": "A test email from Altinn Notifications",
    "body": "Test email",
    "contentType": "Plain"
  },
  "links": {
    "self": "https://platform.at22.altinn.cloud/notifications/api/v1/orders/59b1d86d-fe39-44e5-b47f-f4677e610f32",
    "status": "https://platform.at22.altinn.cloud/notifications/api/v1/orders/59b1d86d-fe39-44e5-b47f-f4677e610f32/status"
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tba76 tba76 tba76 approved these changes

Assignees
No one assigned
Labels
review/domain-model-changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acn-sbuad @SandGrainOne @tba76